-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin Language Supports #11307
base: main
Are you sure you want to change the base?
Kotlin Language Supports #11307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. It won't build because of missing tests, you can follow https://github.com/jhipster/jhipster-lite/blob/main/documentation/module-creation.md for modules implementation steps
Assert.notNull("properties", properties); | ||
|
||
//@formatter:off | ||
return moduleBuilder(properties) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
//@formatter:off
return moduleBuilder(properties)
.gitIgnore()
.comment("Kotlin Language")
.and()
.gradlePlugins()
.plugin(kotlinPluginManagement())
.and()
.build();
//@formatter:on
}
.slug(GRADLE_KOTLIN) | ||
.withoutProperties() | ||
.apiDoc("Extra Language", "Add Kotlin Language Supports") | ||
.organization(JHipsterModuleOrganization.builder().feature(EXTRA_LANGUAGE).addDependency(GRADLE_JAVA).build()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should be in a dedicated feature, I don't see the point here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is hoped that the addition of Kotlin related components can be completed when the project is initialized, instead of configuring the project again after initializing the project. This will be great for some people who find it troublesome to start writing programs in Kotlin after the project initialization is completed.
Message has been translated and may not be accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but this only needs to be a module, no need for the feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where should that be placed? Or should it be removed and added manually by the project creator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JHipsterModuleOrganization.builder().feature(EXTRA_LANGUAGE).addDependency(GRADLE_JAVA).build()
=> JHipsterModuleOrganization.builder().addDependency(GRADLE_JAVA).build()
just remove the feature :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I misunderstood. I already know how to fix this problem.
I'll add some tests to this module later |
It may seem a little rough, but it works.
Issues: #11301