Change from degrees to radians and specify the data type for emis

jialinl6 · Aug 29, 2024 · a5dafb7 · a5dafb7
1 parent 9e5b4e3
commit a5dafb7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/docs/src/composing_models.md b/docs/src/composing_models.md
@@ -73,7 +73,7 @@ using ModelingToolkit:t
 @parameters lat = deg2rad(40.0f0) [unit=u"rad"]
 @parameters lon = deg2rad(-97.0f0) [unit=u"rad"]
 @parameters lev = 1
-emis, emis_updater = NEI2016MonthlyEmis("mrggrid_withbeis_withrwc", lon, lat, lev)
+emis, emis_updater = NEI2016MonthlyEmis("mrggrid_withbeis_withrwc", lon, lat, lev; dtype=Float64)
 
 model_noemis = couple(SuperFast(),FastJX()) # A model with chemistry and photolysis, but no emissions.
 model_withemis = couple(SuperFast(), FastJX(), emis) # The same model with emissions.

diff --git a/test/EarthSciData_test.jl b/test/EarthSciData_test.jl
@@ -3,10 +3,10 @@ using Test, Dates, ModelingToolkit, DifferentialEquations, EarthSciMLBase, Dynam
 
 @testset "NEI2016Extension3way" begin
 
-    @parameters lat = 40
-    @parameters lon = -97
+    @parameters lat = deg2rad(40.0f0) [unit=u"rad"]
+    @parameters lon = deg2rad(-97.0f0) [unit=u"rad"]
     @parameters lev = 1
-    emis = NEI2016MonthlyEmis("mrggrid_withbeis_withrwc", lon, lat, lev; dtype=Float64)
+    emis, emis_updater = NEI2016MonthlyEmis("mrggrid_withbeis_withrwc", lon, lat, lev)
 
     model_3way = couple(FastJX(), SuperFast(), emis)
 
@@ -21,8 +21,8 @@ end
 
 @testset "GEOS-FP" begin
 
-    @parameters lat = 40
-    @parameters lon = -97
+    @parameters lat = deg2rad(40.0f0) [unit=u"rad"]
+    @parameters lon = deg2rad(-97.0f0) [unit=u"rad"]
     @parameters lev = 1
     geosfp = GEOSFP("4x5")