Fix USBIP_CMD_UNLINK behaviour
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completely misunderstood the intent of
USBIP_CMD_UNLINKto mean something else than it's supposed to be. In the current implementations, the correct behavior would be close to a no-op, because we handle all requests in a serial fashion (although #34 might provide the possibility of cancelling URBs).I have removed the test that reflects the misunderstanding. I do not think it's worth writing a new test for the no-op behavior.
@jiegec: I'm not sure how many client libraries actively send these unlink requests, but I think this would warrant a patch release nonetheless. It might be a quite severe regression, rendering the library unusable for many people.
Fixes #39