fixing indentation in the audio_time_features function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the audio_time_features function, you accidentally included the rest of the function in the for on line 525. What happens now is it only goes into the first iteration of the for loop and learns from the first segment of this audio file. What you intended to do was have it go through all of the segments and have the featurelist be an average of all of the segments. Therefore the changes I made to this code fix that problem. (You did it correctly in load_audioclassify.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the audio_time_features function, you accidentally included the rest of the function in the for on line 525. What happens now is it only goes into the first iteration of the for loop and learns from the first segment of this audio file. What you intended to do was have it go through all of the segments and have the featurelist be an average of all of the segments. Therefore the changes I made to this code fix that problem. (You did it correctly in load_audioclassify.py)