WIP: Feature/day 7 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimgerth
commented
Jan 3, 2021
| } | ||
| } | ||
|
|
||
| println!("{:#?}", contained_in_rules); |
There was a problem hiding this comment.
Remove debug print. (Can be added in #11)
|
|
||
| let containers = get_containers("shiny gold", &contained_in_rules); | ||
|
|
||
| // println!("{:#?}", containers); |
|
|
||
| // println!("{:#?}", containers); | ||
|
|
||
| containers.len() as i32 |
There was a problem hiding this comment.
Consider inlining containers.
| total | ||
| } | ||
|
|
||
| fn parse_rules(input: Vec<&str>) -> HashMap<&str, HashMap<&str, i32>> { |
There was a problem hiding this comment.
Move passe_rules above the other two helper functions.
| get_content_count("shiny gold", &rules) | ||
| } | ||
|
|
||
| fn get_containers<'a>( |
There was a problem hiding this comment.
Add a function get_containers_count to wrap the len() call on the HashSet.
| } | ||
|
|
||
| fn get_content_count(color: &str, rules: &HashMap<&str, HashMap<&str, i32>>) -> i32 { | ||
| let rule = rules.get(color).expect("Color not listed in rules."); |
There was a problem hiding this comment.
Default to 0 without panicking!
| let bag_rules_regex = Regex::new(r"bags contain (.*).").unwrap(); | ||
| let bag_rule_regex = Regex::new(r"(\d+) (\w+ \w+) \w+").unwrap(); | ||
|
|
||
| // Parse rules. |
There was a problem hiding this comment.
Remove comment or reword to be more helpful.
Signed-off-by: Jim Gerth <[email protected]>
Signed-off-by: Jim Gerth <[email protected]>
Bags contain different types of other bags. Especially when wanting to determine how many different types of bags a bag can contian, a set is more suitable for the problem, as duplicates are meaningless and even harmful in this situation. Signed-off-by: Jim Gerth <[email protected]>
Signed-off-by: Jim Gerth <[email protected]>
Signed-off-by: Jim Gerth <[email protected]>
Signed-off-by: Jim Gerth <[email protected]>
Both part 1 and part 2 used this code, thus refactored into its own function. Signed-off-by: Jim Gerth <[email protected]>
jimgerth
force-pushed
the
feature/day-7
branch
from
bb7e0e8 to
b32a833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.