Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove inputs state from client #6207

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Oct 1, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/client labels Oct 1, 2024
@JoanFM JoanFM force-pushed the fix-remove-inputs-state-client branch from 52d353e to a2dce61 Compare October 1, 2024 08:17
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (c933e49) to head (a2dce61).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
jina/clients/base/__init__.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #6207       +/-   ##
===========================================
+ Coverage   19.02%   54.62%   +35.60%     
===========================================
  Files         150      150               
  Lines       14226    14216       -10     
===========================================
+ Hits         2706     7766     +5060     
+ Misses      11520     6450     -5070     
Flag Coverage Δ
jina 54.62% <92.85%> (+35.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM merged commit 47eb5f0 into master Oct 1, 2024
130 of 131 checks passed
@JoanFM JoanFM deleted the fix-remove-inputs-state-client branch October 1, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/client size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant