literate-elisp-refs--read-all-buffer-forms now takes SYMBOLS-WITH-POS argument
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 25, 2023 23:24
...so, the advice (literate-elisp-refs--read-all-buffer-forms) is updated accordingly.
(note that I haven't actually tested this in Emacs pre-28.3, but it _should_ work, now)
|
@TinaRussell Thanks for the pull request. For me, I usually edit the original org files, then use the code in section release current library to update the elisp file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elisp-refs--read-all-buffer-formsnow takes two arguments (BUFFER and SYMBOLS-WITH-POS) instead of one, so the around adviceliterate-elisp-refs--read-all-buffer-formsneeds to take three arguments, now (the original function plus the two arguments it takes). This PR makes that change.There are two problems: the first is that when writing the commit messages, I forgot that
elisp-refsisn’t an internal Emacs package and assumed that the change toelisp-refs--read-all-buffer-formshappened with Emacs 28.3, so my commit message for the second commit is a bit misleading (it should say “make compatible with older versions of elisp-refs”). (If compatibility with older versions ofelisp-refsisn’t important to you, you can omit that commit entirely; it uses somecl-defunmagic to make it so the advice can be called with either set of arguments.)The second problem is that the change to
elisp-refs--read-all-buffer-formswas made to take advantage of the new function in Emacs 29,read-positioning-symbols. Now, if the new SYMBOLS-WITH-POS argument is non-nil,elisp-refs--read-all-buffer-formswill useread-positioning-symbolsinstead ofread. Given that the purpose of theliterate-elisp-refs--read-all-buffer-formsadvice is to replace thereadfunction withliterate-elisp-read-internaltemporarily when necessary, I’m assuming we’ll need aliterate-elispequivalent toread-positioning-symbolsas well, and to make theliterate-elisp-refs--read-all-buffer-formsadvice aware of it. (I’m not on Emacs 29, yet, and I don’t know howread-positioning-symbolsworks, so this PR is just a quick fix so that theliterate-elisp-refs--read-all-buffer-formsadvice doesn’t return a “wrong number of arguments” error.)