Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move block_cost_limit tracking to BankingStage in preparation for SIMD-0207 #753

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

buffalu
Copy link
Contributor

@buffalu buffalu commented Jan 15, 2025

Problem

Previously:

  • we’d manually adjust the cost tracker block_cost_limit in bundle stage based on progress through bank ticks.
  • each new bank would do CostTracker::default()
  • there was some issues here, if we were processing a lot of bundles towards the end of the slot, the reservation wasn’t “un-reserved”.

Summary of Changes

  • SIMD-0207 activates a higher CU limit at epoch boundary when the feature is added
  • v2.1 propagates cost tracker parameters through banks in Bank::new_from_parent
  • Instead of handling cost tracker reservation in BundleStage, we pass a callback that defines the behavior of how cost tracker handles the bank ticks to banking stage. This gets propagated down to the cost tracker

@buffalu buffalu force-pushed the lb/simd_0207_bundles branch from 970089c to aaf5ec7 Compare January 16, 2025 21:12
@buffalu
Copy link
Contributor Author

buffalu commented Jan 17, 2025

need to revist this - change is breaking CI. cost tracker now copied from the parent bank

@buffalu buffalu changed the title Ensure the BundleReservedSpaceManager updates block cost limits for SIMD-0207 Move block_cost_limit tracking to BankingStage in preparation for SIMD-0207 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants