-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move block_cost_limit tracking to BankingStage in preparation for SIMD-0207 #753
Open
buffalu
wants to merge
12
commits into
master
Choose a base branch
from
lb/simd_0207_bundles
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalu
force-pushed
the
lb/simd_0207_bundles
branch
from
January 16, 2025 21:12
970089c
to
aaf5ec7
Compare
need to revist this - change is breaking CI. cost tracker now copied from the parent bank |
buffalu
changed the title
Ensure the BundleReservedSpaceManager updates block cost limits for SIMD-0207
Move block_cost_limit tracking to BankingStage in preparation for SIMD-0207
Jan 17, 2025
jedleggett
approved these changes
Jan 22, 2025
segfaultdoc
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously:
Summary of Changes