WIP: Use usrsctp only from dedicated single thread. #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstyura
changed the title
|
Did you run into an issue with the SCTP threading that prompted this? |
bertm
reviewed
Jun 12, 2020
| // Leave SCTP thread ASAP | ||
| TaskPools.IO_POOL.submit(() -> | ||
| { | ||
| innerSctpDataSender.send(newBuf, 0, length); |
There was a problem hiding this comment.
Delegating to just any IO thread breaks outgoing SCTP packet order when the machine is under load.
There was a problem hiding this comment.
The underlying transport (udp) doesn't guarantee order either
There was a problem hiding this comment.
You're right. Thanks for pointing out that we're not dealing with user message here, but rather with the underlying protocol. I missed that.
|
@bbaldino ah, sorry, I've missed your comment. What I was trying to fix is to move |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves calling usrsctp API into dedicated single thread to reduce chances of multi-threading issues.
When
usrsctpis itself updated to the version which has support of disabling internalSCTP Timerthread thenusrsctpwill not be used concurrently at all.