Only gha changes #13
Only gha changes #13
Conversation
| @@ -0,0 +1,26 @@ | |||
| name: install_node_dependencies | |||
There was a problem hiding this comment.
Don't need the actions in this folder anymore, right?
There was a problem hiding this comment.
So you are suggesting to move all the actions under .github/workflows/ or create a actions folder under .github/workflows/ like this .github/workflows/actions ?
There was a problem hiding this comment.
I think setup_python_env is not required because actions/setup-python@v5 already sets up python, and the other two actions can just be steps in the workflow.
There was a problem hiding this comment.
Oh wait, it installs test requirements, you can rename the action instead.
There was a problem hiding this comment.
Actually I need to rename it correctly instead of setup python it should be "Install Python dependencies"
name: setup_python_env
description: Setup Python environment
runs:
using: composite
steps:
- name: Install Python dependencies
run: |-
pip install git+https://github.com/kedro-org/kedro@main
pip install -r package/test_requirements.txt -r demo-project/src/docker_requirements.txt -U
shell: bash
- name: Echo package versions
run: |-
python -V
pip freeze
shell: bash
There was a problem hiding this comment.
It's upto you actually, I think having them as reusable actions is also not a bad setup!
There was a problem hiding this comment.
It's upto you actually, I think having them as reusable actions is also not a bad setup!
It is about "Don't need the actions in this folder anymore, right?" ?
There was a problem hiding this comment.
We just have these as steps in kedro but maybe it makes more sense to have them as actions and we can do smth like this in Kedro too. ^
| name: Run all checks on Kedro-Viz | ||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Can actually just add -
schedule:
- cron: 0 1 * * *
And get rid of daily.yml
There was a problem hiding this comment.
Okay, like this
on:
workflow_call:
workflow_dispatch:
schedule:
- cron: 0 1 * * *
So all-checks.yml will work as standalone and reusable workflow right?
There was a problem hiding this comment.
Yeah, because daily.yml doesn't have any other thing except for calling this workflow!
.github/workflows/e2e-tests.yml
Outdated
| path: ~\AppData\Local\pip\Cache | ||
| key: ${{inputs.os}}-python-${{inputs.python-version}} | ||
|
|
||
| - name: Setup Python environment |
There was a problem hiding this comment.
In CircleCI here https://github.com/jitu5/kedro-viz/blob/main/.circleci/continue_config.yml#L143
"Setup Python environment" is one of the step for e2e-tests.
There was a problem hiding this comment.
But the second step above already sets up python ^
There was a problem hiding this comment.
I realised it actually installs kedro and other requirements, maybe rename the action.
Description
Development notes
QA notes
Checklist
RELEASE.mdfile