Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resume downloads automatically #603

Merged
merged 9 commits into from
Apr 12, 2024
Merged

resume downloads automatically #603

merged 9 commits into from
Apr 12, 2024

Conversation

jjjake
Copy link
Owner

@jjjake jjjake commented Aug 9, 2023

First pass at making downloads resume automatically.

@jjjake
Copy link
Owner Author

jjjake commented Aug 9, 2023 •
edited
Loading

TODO:

  • Fix tests... should resume be automatic? If so, should we worry about the use case where a file might have changed remotely in between download attempts (in this case, with this patch currently, ia would concatenate the contents of the new remote file to the partially downloaded local file, creating a corrupt file).
  • Automatically resume on retry (i.e. via http adapter, not retries between separate processes).

@jjjake jjjake merged commit 6ba9bcf into master Apr 12, 2024
20 checks passed
@jjjake jjjake deleted the resume-download branch April 12, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jjjake