Remove circular reference check on item metadata hashing

.github/workflows/tox.yml

@@ -8,11 +8,14 @@ jobs:
       max-parallel: 1  # Avoid timeout errors
       matrix:
         python: ['3.8', '3.9', '3.10', '3.11', '3.12', 'pypy-3.9', 'pypy-3.10']
+        envname: ['py']  # To allow testing more special configurations below
+        include:
+          - { python: '3.12', envname: 'py312ujson' }  # With optional ujson dependency
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python }}
           cache: pip
       - run: pip install tox
-      - run: tox -e py
+      - run: tox -e ${{ matrix.envname }}

internetarchive/item.py

@@ -131,8 +131,7 @@ def __hash__(self) -> int:
         without_excluded_keys = {
             k: v for k, v in self.item_metadata.items()
             if k not in self.EXCLUDED_ITEM_METADATA_KEYS}
-        return hash(json.dumps(without_excluded_keys,
-                               sort_keys=True, check_circular=False))  # type: ignore
+        return hash(json.dumps(without_excluded_keys, sort_keys=True))  # type: ignore
 
 
 class Item(BaseItem):

tests/test_item.py

@@ -706,3 +706,7 @@ def test_modify_metadata(nasa_item, nasa_metadata):
                                   secret_key='b')
         # Test that item re-initializes
         assert nasa_item.metadata['title'] == 'new title'
+
+
+def test_hash_item(nasa_metadata, nasa_item, session):
+    assert hash(nasa_item)

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py38,py39,py310,py311,py312,pypy39,pypy310
+envlist = py38,py39,py310,py311,py312,py312ujson,pypy39,pypy310
 
 [testenv]
 deps = -r tests/requirements.txt
@@ -21,3 +21,8 @@ basepython=python3.11
 
 [testenv:py312]
 basepython=python3.12
+
+[testenv:py312ujson]
+basepython=python3.12
+deps = -r tests/requirements.txt
+       ujson