Clear Jupyter notebook cells for string checks

jkotilahti · Aug 17, 2022 · 326c3b0 · 326c3b0
1 parent 4cdf7ba
commit 326c3b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -80,10 +80,19 @@ check_confidential_strings:
   variables:
     GIT_DEPTH: 0
     GIT_STRATEGY: clone
+    FILTER_BRANCH_SQUELCH_WARNING: 1
   script:
+    - pip install nbconvert
+    - git checkout "$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME"
+    # go through relevant history and clear output from notebooks
+    - >
+      git filter-branch --tree-filter
+      'python3 -m nbconvert --clear-output --inplace notebooks/*.ipynb || true'
+      -- $(git merge-base remotes/origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME HEAD)..HEAD
+    - python3 -m nbconvert --clear-output --inplace notebooks/*.ipynb
     - >
       bash ci/check_files_for_strings.sh "$KQC_CONFIDENTIAL_STRINGS"
-      "remotes/origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" "remotes/origin/$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME"
+      "remotes/origin/$CI_MERGE_REQUEST_TARGET_BRANCH_NAME" "$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME"
   only:
     refs:
       - merge_requests

diff --git a/tox.ini b/tox.ini
@@ -24,4 +24,4 @@ commands_post =
 [testenv:static_analysis]
 commands =
     python -m pylint klayout_package/ tests/ {posargs}{env:CODEQUALITY_JSON:}
-    python -m nbqa pylint notebooks/ --disable=W0104 {posargs}{env:CODEQUALITY_NB_JSON:}
+    python -m nbqa pylint notebooks/ --disable="W0104,C0103" {posargs}{env:CODEQUALITY_NB_JSON:}