Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate publish from snapshot. #126

Open
kommendorkapten opened this issue Jun 28, 2023 · 2 comments
Open

Separate publish from snapshot. #126

kommendorkapten opened this issue Jun 28, 2023 · 2 comments

Comments

@kommendorkapten
Copy link
Collaborator

Today the publish (deploy) happens as a step in either the snapshot or online version bump workflow. Preferably is to have deployment as a single workflow that other workflows can call into. This would also make it easier in the future to force a deployment to recover from a situation where the deployment fails.

One example today: if the snapshot job runs (and successfully updates the main branch), but deployment fails, following snapshot jobs does not publish as the snapshot did not update anything -- main branch is in a good state.

@jku
Copy link
Owner

jku commented Jun 29, 2023

As detail from #125:

  • snapshot and online-version-bump should not decide or take into account the published URLs (currently the actions have arguments that affect the publishing URLs)
  • I can think of two options:
    1. snapshot and online-version-bump still produce a "ready.to-publish" github artifacts (a single one or separate artifacts for metadata and targets). publish workflows then use these artifacts -- the default github-pages publish workflow/action could then have a way to define which URL paths to use for the publish.
    2. snapshot and online-version-bump don't produce GH artifacts at all, they just inform the workflow that a publish can be made. The publish workflows then run separate command(s) to produce the artifacts and then publishes them

The upside of option 1 it that it keeps the publish workflow/action quite simple: just handle the the GH artifacts. It does mean both snapshot and online-version-bump have to produce those artifacts though.

@jku
Copy link
Owner

jku commented Jul 4, 2023

A related note: we may want to annotate repository publish in the git repo itself. The light weight option is a branch that follows main and is updated in the publish action: the "publish" branch always points to the last commit that has been published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants