Configurable deployment #125
Conversation
Signed-off-by: Fredrik Skogman <[email protected]>
|
For backwards compatibility do we want to have default metadata path to |
| metadata_path: | ||
| description: 'Path where to store the metadata files in the published repository' | ||
| required: true | ||
| default: '/' |
There was a problem hiding this comment.
I think I would prefer "metadata" as the default -- I think combining the directories like this does (so that targets dir is inside the metadata dir) has more potential for issues and I do not think we should recommend that
There was a problem hiding this comment.
wait, this has both "required" and "default" -- does that make sense?
There was a problem hiding this comment.
Yeah, let me remove the default values. They are set in the workflows in the template repository.
There was a problem hiding this comment.
LGTM:
- I think metadata and targets should go to separate directories by default but that's just mild preference (since the workflow sets it anyway)
- long term we should separate publishing directories from the directories used in online-version-bump and snapshot... but I think we have an issue for that already
Signed-off-by: Fredrik Skogman <[email protected]>
You are referring this this issue, right: #126 |
Closes #122
The version bump and snapshot composite actions are now updated to accept two new parameters:
metadata_path: the path inside thepublishdirectory for the metadata, default is/, ie the root of the publish directorytargets_path: the path inside thepublishdirectory for the targets, default istargets.The parameters are provided to the
publishmethod which makes sure to publish the metadata and targets accordingly, and then the final artifact is uploaded to pages.