Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard setting of rspec formatter #42

Closed
wants to merge 1 commit into from
Closed

Remove hard setting of rspec formatter #42

wants to merge 1 commit into from

Conversation

chrsgrrtt
Copy link

Overcomes deprecation issue: #41

Overcomes deprecation issue, documented at:
#41
@nilbus
Copy link
Collaborator

nilbus commented Mar 25, 2015

Thanks. I'll test it out sometime soon to confirm it works well for me. I'll merge this if so.

@paulgoetze
Copy link

@nilbus Any progress here? I would love to see this in a next release :)

@nilbus
Copy link
Collaborator

nilbus commented Nov 26, 2015

Hmm, I guess I forgot about this! 😵 Thanks for the reminder. I'll try to test it this weekend.

@nilbus
Copy link
Collaborator

nilbus commented Nov 27, 2015

@paulgoetze or @chrsgrrtt I'm having trouble reproducing this deprecation warning, and I believe it's because I'm using some different combination of gems than you. Could you please post a link to a gist containing your Gemfile.lock to help me get on the same relevant gem versions.

Also @paulgoetze, have you confirmed that everything works as you expect after removing the line removed in this pull request?

@paulgoetze
Copy link

Here‘s my Gemfile.lock: https://gist.github.com/paulgoetze/7277af0495c1aa69db15
I get the described deprecation warning with v0.2.2.

However, @chrsgrrtt, I cannot get the gem from your patch-1 branch running (v0.2.3.dev).
If I start up guard with bundle exec guard (which works fine with v0.2.2) it prints the watching message

INFO - Guard is now watching at /my/gem/path

and does nothing where it should run all specs.

If I try to run all specs by pressing RETURN it just fails and prints several error messages that it can‘t find e.g. my shared examples.

@chrsgrrtt chrsgrrtt closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants