Skip to content

Commit

Permalink
Improve CI testing. (envoyproxy#13)
Browse files Browse the repository at this point in the history
The envoy-filter-example CI did not actually verify that a runnable
binary was built since it only ran a test. A change in Envoy resulted in
the binary build from the envoy-filter-example becoming broken.

The submodule hash is updated as part of this commit.  The WORKSPACE
file is modified to include references to the api dependencies added
since the last submodule hash update.

After this is merged a commit to Envoy will update the filter-example
hash for CI to include this commit, and modify do_ci.sh to run this
new test.
  • Loading branch information
dnoe authored and htuch committed Jun 28, 2017
1 parent ae81df0 commit 8442ed7
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 1 deletion.
6 changes: 6 additions & 0 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,9 @@ envoy_cc_test(
"@envoy//test/integration:integration_lib"
],
)

sh_test(
name = "envoy_binary_test",
srcs = ["envoy_binary_test.sh"],
data = [":envoy"],
)
3 changes: 3 additions & 0 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ load("@envoy//bazel:cc_configure.bzl", "cc_configure")
envoy_dependencies()

cc_configure()

load("@envoy_api//bazel:repositories.bzl", "api_dependencies")
api_dependencies()
2 changes: 1 addition & 1 deletion envoy
Submodule envoy updated from 895868 to 252c36
10 changes: 10 additions & 0 deletions envoy_binary_test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#!/bin/bash
#

set -e

# Just test that the binary was produced and can be executed.
# envoy --help will give a success return code if working.
envoy --help

echo "PASS"

0 comments on commit 8442ed7

Please sign in to comment.