run smoke test earlier in the process

jmazzitelli · Nov 16, 2023 · 153576e · 153576e
1 parent 7deb1ca
commit 153576e
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -197,6 +197,12 @@ jobs:
         git commit -m "Release $RELEASE_VERSION"
         
         git push origin $(git rev-parse HEAD):refs/tags/$RELEASE_VERSION-master
+
+        # smoke test the helm charts before we go any further
+        git checkout -b smoketest-master
+        hack/smoke-test-release-branch.sh --release-branch smoketest-master
+        git checkout master
+        git branch -D smoketest-master
   
     - name: Publish Helm charts
       env:
@@ -219,19 +225,14 @@ jobs:
           
           git commit -m "Prepare for next version"
 
-          hack/smoke-test-release-branch.sh --release-branch HEAD
-
           git push origin $(git rev-parse HEAD):refs/heads/$BUILD_TAG
 
-
           gh pr create -t "Prepare for next version" -b "Please, merge to update version numbers and prepare for release $NEXT_VERSION." -H $BUILD_TAG -B $RELEASE_BRANCH
           
         # For a patch release, everything is ready to publish the generated charts.
         # Let's push to master
         elif [[ $RELEASE_TYPE == "patch" ]]
         then 
-          hack/smoke-test-release-branch.sh --release-branch HEAD
-
           git push origin $(git rev-parse HEAD):refs/heads/$BUILD_TAG
 
           gh pr create -t "Prepare for next version" -b "Please, merge to update version numbers and prepare for release $NEXT_VERSION." -H $BUILD_TAG -B master