Refactor: AudioData Memory Management for Improved RAII Compliance
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Don't think it requires any testing |
jmorton06
added a commit
that referenced
this pull request
Jan 18, 2024
commit b5a0f9f Merge: 80f1e57 2d97104 Author: jmorton06 <[email protected]> Date: Sun Dec 31 18:53:46 2023 +0000 Merge pull request #132 from adriengivry/fix/readme-apple-targets Fixed Runtime.xcodeproj path for apple targets commit 2d97104 Author: Adrien GIVRY <[email protected]> Date: Sun Dec 31 11:26:34 2023 -0500 Fixed Runtime.xcodeproj path for apple targets commit 80f1e57 Merge: 648688c 4284ddf Author: jmorton06 <[email protected]> Date: Fri Dec 29 20:42:44 2023 +0000 Merge pull request #131 from jmorton06/dev Dev commit 648688c Merge: 0589c28 c8affd4 Author: jmorton06 <[email protected]> Date: Mon Dec 11 20:08:35 2023 +0000 Merge pull request #129 from adriengivry/reduced-definition-enum-footprint Reduced memory footprint of graphics RHI definitions enums commit 0589c28 Merge: 5eaf2da c528a26 Author: jmorton06 <[email protected]> Date: Mon Dec 11 20:08:07 2023 +0000 Merge pull request #128 from adriengivry/constexpr-constants Made math constants constexpr instead of const commit 5eaf2da Merge: e6f3f97 73b902b Author: jmorton06 <[email protected]> Date: Mon Dec 11 20:05:10 2023 +0000 Merge pull request #127 from adriengivry/smoother-camera-focus Camera focus transition is now smoother commit e6f3f97 Merge: 525a491 d71cf77 Author: jmorton06 <[email protected]> Date: Mon Dec 11 20:04:30 2023 +0000 Merge pull request #126 from adriengivry/refactor/audio-data-raii-compliant Refactor: `AudioData` Memory Management for Improved RAII Compliance commit c8affd4 Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 13:46:09 2023 -0500 Reduced memory footprint of graphics RHI definitions enums commit c528a26 Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 13:33:30 2023 -0500 Made math constants constexpr instead of const (ensure no memory is allocated for them at runtime) commit 73b902b Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 13:25:41 2023 -0500 Updated camera speed for more consistency commit ad7d20e Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 12:51:09 2023 -0500 Camera focus transition is now smoother commit d71cf77 Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 12:03:03 2023 -0500 Updated `AudioData` to be RAII compliant commit 525a491 Merge: 0b2a6d0 b22fd06 Author: jmorton06 <[email protected]> Date: Mon Dec 11 16:40:35 2023 +0000 Merge pull request #125 from adriengivry/better-windows-build-scripts Improved Windows Generation & Build Scripts commit b22fd06 Author: Adrien GIVRY <[email protected]> Date: Mon Dec 11 11:14:54 2023 -0500 Improved Windows Generation & Build Scripts * Added vswhere.exe to locate MSBuild executable * Added common script to generate a vs project * Added common script to build a vs project (using vswhere.exe) * Updated GenerateVSX.bat scripts to use Common/GenerateVSProject.bat * Updated BuildWindow*.bat to use Common/BuildWindowsTarget.bat * Renamed GenerateVS.bat to GenerateVS17.bat for consistency commit 0b2a6d0 Merge: 57fe40d 479f759 Author: jmorton06 <[email protected]> Date: Thu Dec 7 10:33:24 2023 +0000 Merge pull request #124 from jmorton06/dev Dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue (if no issue has been made)
In the existing codebase, the memory allocations for
AudioDataare externally handled. This setup poses the risk of memory leaks, especially when dealing with the external allocation and subsequent release of memory forAudioData::Datawithin theSounddestructor. To enhance RAII compliance and mitigate potential memory issues, this pull request proposes a transition to utilizingstd::vectorfor managingAudioDatamemory. This adjustment ensures that memory deallocation responsibilities are intrinsic to theAudioDataclass itself, thereby addressing the current shortcomings and promoting a more robust and leak-resistant code structure.Testing
Limited coverage for this PR. Minimal expected impact, seeking guidance from @jmorton06 on implementing appropriate tests.