Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UK translations: git-annotate and related #117

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

burlakvo
Copy link
Contributor

@burlakvo burlakvo commented Oct 4, 2024

Add Ukrainian translation for strings related to blame-options, line-range-format, and git-annotate

@jnavila
Copy link
Owner

jnavila commented Oct 6, 2024

Hello @burlakvo ,

I do not know how you edited your po file, but there's at least a syntax error in it at line 289 where the double-quote characters are not escaped.

@jnavila
Copy link
Owner

jnavila commented Oct 6, 2024

Another remark: all the commits must be signed off by their author. That's done by adding "Signed-off-by:" trailer to the commit message. See https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---no-signoff for more details.

Thank you

@burlakvo
Copy link
Contributor Author

burlakvo commented Oct 6, 2024

Finally figured it out with Ruby, so tested it normally. Translation fixed, improved, and added new for line-range-format related strings.

Forgot about "signed-off-by", I will fix it soon

@burlakvo burlakvo changed the title Add UK translations: blame-options, git-annotate Add UK translations: blame-options, git-annotate, line-range-format Oct 7, 2024
@burlakvo burlakvo changed the title Add UK translations: blame-options, git-annotate, line-range-format Add UK translations: git-annotate and related Oct 7, 2024
@burlakvo
Copy link
Contributor Author

burlakvo commented Oct 7, 2024

Signed off

@jnavila jnavila merged commit 0fe9015 into jnavila:master Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants