-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release #79
New release #79
Conversation
d6aea04
to
1f88052
Compare
ec92f81
to
891b67d
Compare
891b67d
to
6f4bdb5
Compare
@bf4 @jnunemaker I'm ready with all the pre-release tasks I wanted to do before we can release the new I'm happy to merge in this PR and tag the new release commit in the repo any time from now. Let me know if you would like to add anything else. Also, could you help me with releasing it to RubyGems? |
@@ -1,25 +1,26 @@ | |||
# crack | |||
|
|||
[![Build Status](https://travis-ci.org/jnunemaker/crack.svg?branch=master)](https://travis-ci.org/jnunemaker/crack) | |||
[![Test](https://github.com/jnunemaker/crack/actions/workflows/test.yml/badge.svg)](https://github.com/jnunemaker/crack/actions/workflows/test.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good |
Released 0.4.6 |
We already have a few fixes merged in, we should do a release soon to make sure that this gem remains usable.
ToDo:
My Questions:
Should we add a minimum Ruby version?
I wasn't able to set up the environment for Ruby <2.0, and there are already EOL for ages.
Should we release it as 1.0.0 as well?
The gem seems to be really stable, but most of the gems / projects are referencing it as
~> 0.4.x
, so we definitely need a0.4.6
first.