Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Migration v17 #126

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Angular Migration v17 #126

wants to merge 16 commits into from

Conversation

kashgurung
Copy link

@kashgurung kashgurung commented Mar 9, 2024

This PR contains the following changes:
1. Upgraded Angular version from 8.2.14 to 17.2.3 (latest).
2. Migrated TSLint to ESLint.
3. Migrated Protector to Cypress for E2E testing.
4. Updated the Unit Test configurations.

@kashgurung
Copy link
Author

kashgurung commented Mar 9, 2024

Test Cases
Screenshot 2024-03-10 at 1 45 36 AM
Screenshot 2024-03-10 at 1 45 09 AM
Screenshot 2024-03-10 at 1 48 30 AM

@kashgurung kashgurung marked this pull request as draft March 14, 2024 14:23
@kashgurung kashgurung marked this pull request as ready for review March 15, 2024 06:21
@kashgurung
Copy link
Author

kashgurung commented Mar 17, 2024

@MrElectroNick Hi, could you please review this PR and let me know if anything needs to be updated. Thanks!

@MrElectroNick
Copy link
Collaborator

Hi @kashgurung, I'll need to find some time to review and merge it. Thanks for the effort!

@ultrasonicsoft
Copy link

@kashgurung Thanks!
@MrElectroNick Eagerly waiting for this PR to be merged so that I don't have to use ngx-jodit as a workaround for my angular project which is on 17 version. Appreciate your help.

@kashgurung kashgurung changed the title Angular Migration Angular Migration v17 May 16, 2024
@digitalcraftco
Copy link

@kashgurung Since this hasn't been merged yet could you also make an Angular 18 PR? Or just update this one? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants