addmykakpoindex.html #239
Open
addmykakpoindex.html #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpentler
reviewed
Jan 30, 2018
| @@ -1267,6 +1268,19 @@ def animalfactsbot(reddit): | |||
| 'The red kangaroo is the largest marsupial in the world.', | |||
| 'Kangaroos usually live to around six years old in the wild.', | |||
| ) | |||
| KAKAPO_FACTS = ( | |||
| 'The kakapo is the worlds only fligletless parrot and is also unusual in being nocturnal.', | |||
mpentler
reviewed
Jan 30, 2018
| @@ -270,6 +270,7 @@ def check_comment_for_animal(comment, reddit): | |||
| botengine('jackal', '\sjackals?\s', reddit, JACKAL_FACTS, comment) | |||
| botengine('jellyfish', '\sjelly ?fish(es)\s', reddit, JELLYFISH_FACTS, comment) | |||
| botengine('kangaroo', '\skangaroos?\s', reddit, KANGAROO_FACTS, comment) | |||
| botengine('kakapo', '\skakapo?\s', reddit, KAKAPO_FACTS, comment) | |||
There was a problem hiding this comment.
Missing an s in the regex here - check the other entries
mpentler
reviewed
Jan 30, 2018
| @@ -87,6 +87,7 @@ You can see the bot in action at https://www.reddit.com/user/AnimalFactsBot/comm | |||
| * jackal | |||
| * jellyfish | |||
| * kangaroo | |||
| * kakapo | |||
There was a problem hiding this comment.
This list has been capitalised now. If you can grab the latest repo and capitalise this that’ll sort it.
|
Some notes added for you - but assuming Joel says the animal can go in it looks alllllmost good :) |
|
@Logias are you still around? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.