Added Baboon Facts #326
Open
Added Baboon Facts #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AntonTru3 ! Any chance you can take the latest codebase and try submitting these again? May also want to check your indents etc for consistency. Thanks! |
|
@antontru3 are you still around? Shall we get this fixed up? Happy to pull it when it’s all sorted. |
mpentler
reviewed
Jan 2, 2019
animalfacts.py
Outdated
| @@ -227,6 +227,7 @@ def check_comment_for_animal(comment, reddit): | |||
| botengine('atlantic puffin', '\spuffins?\s', reddit, ATLANTIC_PUFFIN_FACTS, comment) | |||
| botengine('honeybadger', '\shoney badgers?\s', reddit, HONEYBADGER_FACTS, comment) # Needs to be here out of order so that it gets picked up before regular badger | |||
| botengine('badger', '\sbadgers?\s', reddit, BADGER_FACTS, comment) | |||
| botengine('baboon', '\sbaboon?\s', reddit, BABOON_FACTS, comment) | |||
There was a problem hiding this comment.
Mind making this 4 spaces instead of a tab, please? Sorry!
|
Tabs everywhere instead of spaces. All we need is a rebase and a quick check of your additions and it's good to go. |
Corrected some spellings, grammar, and indentation issues. Also a comma.
Corrected animal order (Baboon)
|
I’ve fixed all of the issues with the additions, but there’s the conflicts to sort too. I’ll save that for another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.