Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] retrieve the model to allow deletion to fire model events #381

Conversation

ivannovak
Copy link
Contributor

@ivannovak ivannovak commented Oct 8, 2024

Summary

Directly deleting the database entry prevents the deletion model event from firing.

Resolves #382

Explanation

This pull request retrieves the relevant model prior to issuing the deletion so as to trigger the deletion model event.

Checklist

  • I've read this template
  • I've checked reviewed this PR myself, ensuring consistency and quality with the rest of the project
  • I've given a good reason as to why this PR exposes new / removes existing user data

@joelbutcher joelbutcher changed the title retrieve the model to allow deletion to fire model events [6.x] retrieve the model to allow deletion to fire model events Oct 9, 2024
@joelbutcher joelbutcher merged commit f10c4fc into joelbutcher:6.x Oct 9, 2024
38 checks passed
@ivannovak ivannovak deleted the allow-deletion-to-fire-registered-model-events branch October 9, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The deletion model event is not firing when removing a connected account.
2 participants