Feature/extend inventory functions

[pasco1995]

Added functions

• to get all inventory items
• to change existing inventory item's value
• [to get an existing keystore item's index]

[joelguittet]

Hello @pasco1995

Really good contribution with respect of the current code format and comments, I really appreciate it! I executed the Sonarcloud analysis, nothing to report. Some few minor comments.
I also suggest to cleanup the commits. 2 commits are enough and I usually (must have) use the following format: "topic: purpose" so this can for example in this PR:

• "core: utils: add function to get item index in key-store"
• "add-ons: inventory: add function to update a single item in the inventory"

Thanks for your contribution to this project
Joel

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[joelguittet]

Thanks @pasco1995 for the update, and my sincere apologize for the delay to review it.
The commit 54bc3a6 is not good, it shows a lot of files modified, which is not normal. Probably you simply just need to rebase your branch on top of master after updating your fork. Please tell me if you need some assistance for that, I'm happy to help if required.
Also one minor improvement I have seen in the function used to search for the item index.
The CI also blocks for the code format. You can execute "./.github/workflow/do_code_format.sh" to fix it.

Regards
Joel

[joelguittet]

Hello @pasco1995
Any news here ?
Joel

[pasco1995]

Hello @pasco1995 Any news here ? Joel

Hello, try to fix it this weekend.

[joelguittet]

Hello @pasco1995
Thanks for the update, look good except the code format checking not passing, no more comment on the code and Sonar testing passing.
If you have properly executed the do_code_format.sh script, please ensure the version of the clang-format tool. The CI executes using ubuntu 24.04.
Joel

[joelguittet]

Note @pasco1995 if you have not Ubuntu 24.04 just tell me I will check the difference so you can apply it.

[pasco1995]

Hi @joelguittet, that would be helpful, thanks.

The current output of the do_code_format.sh script only views the file path and name. Is it possible that it can tell the line number and the conspicuous code formatting as well ?

[joelguittet]

@pasco1995 for the modification to apply here is a git diff to do (variables ret and index must be vertically aligned), this will satisfy the verification:

diff --git a/add-ons/inventory/src/mender-inventory.c b/add-ons/inventory/src/mender-inventory.c
index 3378071..e5d456d 100644
--- a/add-ons/inventory/src/mender-inventory.c
+++ b/add-ons/inventory/src/mender-inventory.c
@@ -178,7 +178,7 @@ mender_err_t
 mender_inventory_set_item(char *name, char *value) {
 
     mender_err_t ret;
-    int index;
+    int          index;
 
     /* Take mutex used to protect access to the inventory key-store */
     if (MENDER_OK != (ret = mender_scheduler_mutex_take(mender_inventory_mutex, -1))) {

The current output of the do_code_format.sh script only views the file path and name. Is it possible that it can tell the line number and the conspicuous code formatting as well ?

I will think about that, this could be very helpful yes! I note this in my TODO list :-)

Joel

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[joelguittet]

@pasco1995 all good now! Thanks a lot for the job done here and your patience :-) PR is merged.