Fix names of anonymous classes defined in lambdas #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johannescoetzee
commented
Jan 6, 2025
Comment on lines
-122
to
+127
| case (Some(returnTpe), Some(parameterTpes)) if !containsEmptyType => | ||
| composeMethodLikeSignature(returnTpe, parameterTpes) | ||
| case (Some(returnType), Some(parameterTypes)) if !containsEmptyType => | ||
| composeMethodLikeSignature(returnType, parameterTypes) |
There was a problem hiding this comment.
This is just a typo I saw while working on this. I could move this to a separate PR, but I thought I'd include it here since the PR is relatively small anyways
maltek
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an anonymous class is defined, the name of the enclosing scope is prepended to the anonymous class name to ensure uniqueness. I previously used an empty method node for lambda methods, however, so the enclosing scope name for anonymous classes in lambdas would just be
<empty>. This resulted in duplicate anonymous class names being possible and in an edge case where orphan locals were created in anonymous classes of the same name where one is defined in a lambda in a static scope and one in a non-static scope.This PR fixes this issue by using the actual lambda method node in the scope.