-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raj/4 digits as year #88
Open
dhirajbhandari
wants to merge
104
commits into
joestelmach:master
Choose a base branch
from
dhirajbhandari:raj/4-digits-as-year
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Raj/4 digits as year #88
dhirajbhandari
wants to merge
104
commits into
joestelmach:master
from
dhirajbhandari:raj/4-digits-as-year
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e modifier. Added final and @ tokens
…n larger strings. Necessary tree walking changes are on the way
…3 21:00 to in 5 days'
… day of 2009', 'first to last day of 2 septembers from now'
…ommas in conjunctions, more tests
… a dangling known token at the end of the stream. fixes joestelmach#40
In general, tokens that are substrings should be ignored. Known issues: afri, zfri, afriday, zfriday are still parsed for the following reasons: - 'afri' or 'afriday' are lexed as FRIDAY, with AM dissapearing somewhere - 'zfri' or 'zfriday' are lexed as UTC FRIDAY and are then parsed into a valid date
Conflicts: src/test/java/com/joestelmach/natty/DateTimeTest.java
Eg, (common usage): 2014 should mean Year 2014 rather than Military Time 20:14 - changed DateParser.g to recognize 'formal_year_four_digits' (without the month component) as formal_date - changed DateWalker.g to create 'explicit_year_only_date' from the above and made an alternative for date rule
joestelmach
force-pushed
the
master
branch
2 times, most recently
from
September 28, 2014 03:39
9ad6473
to
b315ced
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse four-digits as Year (YYYY) not time (HHmm)
For eg: treats '2014' as Year 2014 rather than Military Time 20:14