-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Add compile-time language setting #323
base: main
Are you sure you want to change the base?
Conversation
This currently supports Spanish and German (with English being the default), and simply translates the weekdays, although more translations should be added. German translations are from @Kaoala on GH Discussions. Spanish translations are from ltzamatema on Discord. DO is a little hard to read (it looks a little like OO if you're not expecting it). Possibly dO would look better, but I've chosen to keep everything in caps for now. If someone who uses the watch in another language would like to change it, feel free.
Translations from https://chris.bur.gs/sensor-watch-r%C4%81-m%C4%81ori/
Great to see this @WesleyAC! Thanks. Here's a link to my writeup of the Reo Māori translation - similarly to I expect this would be used with |
I saw you mention those on Discord and just added them in a second commit :) The reason And yep, it's used in that way. I'll send a PR to update the docs as well. |
Just want to say I'm using this and the PR has my thumbs up to accept :) thanks @WesleyAC |
I also used a custom patch to set different weekday abbreviations. It would be nice if this PR got merged. The fewer things to maintain in a personal branch the better. We probably should collect places where it makes sense to have translations. https://github.com/joeycastillo/Sensor-Watch/blob/main/movement/watch_faces/complication/alarm_face.c#L42 And the original The entries in https://github.com/joeycastillo/Sensor-Watch/blob/main/movement/watch_faces/settings/preferences_face.c also seem very suitable to receive translations, but I'd have to invest more time in finding proper values for the display for those. |
This currently supports Spanish and German (with English being the default), and simply translates the weekdays, although more translations should be added.
German translations are from @Kaoala on GH Discussions. Spanish translations are from ltzamatema on Discord.
DO is a little hard to read (it looks a little like OO if you're not expecting it). Possibly dO would look better, but I've chosen to keep everything in caps for now. If someone who uses the watch in another language would like to change it, feel free.