International weekday names #396
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new field to track weekday language preference
adding language preference to settings face
add weekday language dictionary
until I can figure out how to make it const again
correcting abbreviation for German Sunday
Ooops, get that extra pref in the array
LED updates only apply to certain pages
need to use watch_utility_get_weekday() from watch_utility.h
take debug back out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: adding internationalized weekday selections in preferences_face
The idea I have about this is that, inside preferences_face, when a user selects current_page == 7, the particular language blinks, indicating that it is changeable, while the weekday name changes, but does not blink, as the user cycles through the different choices.
My C-fu is not that strong, so I welcome feedback. I'm struggling on how to get watch_utility_get_weekday() to see movement_state without it being declared extern. I'm also struggling to get const put in the right places. TIA