Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
days_in_month
towatch_utility_days_in_month
. This is to make the function match other functions found inwatch_utility
, and to avoid conflicts with the upcoming UTZ logic, which also includes a function calleddays_in_month
.day
is held in a 5 bit variable. Before, we added to the day and then checked if it's larger than how many days are in a month. With October, there are 31 days, and that means that it'll write 32 to the bit before changing it to one. However, 32 will overflow to 0.I tested
set_time_face
andtime_left_face
with October being the month to attempt an overflow and they both now work.