Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix months #484

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix months #484

wants to merge 4 commits into from

Conversation

voloved
Copy link
Contributor

@voloved voloved commented Oct 17, 2024

This PR does two things:

  1. It renames days_in_month to watch_utility_days_in_month. This is to make the function match other functions found in watch_utility, and to avoid conflicts with the upcoming UTZ logic, which also includes a function called days_in_month.
  2. There is a bug where if you roll over the current date, the day will start at 0, rather than 1 because day is held in a 5 bit variable. Before, we added to the day and then checked if it's larger than how many days are in a month. With October, there are 31 days, and that means that it'll write 32 to the bit before changing it to one. However, 32 will overflow to 0.

I tested set_time_face and time_left_face with October being the month to attempt an overflow and they both now work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant