Fix Radxa ROCK 4 naming #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit might conflict the pull request that polishes title capitalizing. Do #170 first, then apply this one. |
|
Commit message correction. The 5th generation isn't called Pi either. Pi is a product family of it's own. My bad. |
|
I like the change but I prefer that board ID is unchanged. Changing that will cause broken URLs and stuff. |
|
Ok, I can try to revert the board IDs and update the pull request no problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Radxa ROCK 4 naming. Models doesn't have the name ROCK Pi until 5th generation. Radxa is a little inconsistent with 4SE or "4 SE", but the support pages and product box says "4 SE".