Test to copy directory with files with same name prefix #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test case in gcsfs had a weird behavior where copying a folder also copied the files that has the same name prefix as the folder name. For example:
This PR fixes this behavior. I guess there's a better way to fix this but I had to also remove the
_glob
method for it to work so the_glob
method from the async fs is used.@ianthomas23 @martindurant I created a PR here for now since I need the updates from this other PR for it to work. I'll create a PR with
gcsfs
master branch as the target as soon as the other one is merged.