Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve SF 7 deprecation #190

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Solve SF 7 deprecation #190

merged 2 commits into from
Aug 12, 2024

Conversation

VincentLanglet
Copy link
Contributor

Hi @damienalexandre @lyrixx,

I'm getting the following deprecation with SF 7

The "Symfony\Component\HttpKernel\DependencyInjection\Extension" class is considered internal since Symfony 7.1, to be deprecated in 8.1; use Symfony\Component\DependencyInjection\Extension\Extension instead. It may change without further notice. You should not use it from "JoliCode\Elastically\Bridge\Symfony\DependencyInjection\ElasticallyExtension".

This PR fix it.

lyrixx
lyrixx approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@damienalexandre damienalexandre merged commit 6e04fd7 into jolicode:master Aug 12, 2024
10 checks passed
@damienalexandre
Copy link
Member

Thanks a lot!

@VincentLanglet
Copy link
Contributor Author

You're welcome, could you consider a patch release @damienalexandre ?
Thanks

@damienalexandre
Copy link
Member

Yes here it is: https://github.com/jolicode/elastically/releases/tag/v1.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VincentLanglet @damienalexandre @lyrixx