Refactorings #8
Merged
Refactorings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ancestors of given numbers should include the segment endpoints. This change adds the segment endpoints to methods providing the ancestors of the number.
We should guard that number arguments are within the range of the base segment of the particular fraction tree. That is, that Farey tree numbers are within 0 and 1, octave reduced tree numbers are within 1 and 2, etc. Not doing so causes run-away processes trying to find nodes for numbers outside of their tree's range. This commit adds a validate call to check a number is within the tree's base segment, before executing some methods, like path_to.
Using classes to denote the types of fraction trees doesn't scale well. It requires the user to know which class associates with which range of the tree, and it doesn't support custom tree ranges easily. All the former ability can be achieved using a class instance, and keywords to denote the different known tree ranges. With one class, we can also expand the constructor to accept keyword arguments, which lets us define custom tree ranges more easily. This change does the following: 1. Moves the behaviour of the various FractionTree sub-classes into the FractionTree class. This change also moves most formerly class methods to instance methods in the FractionTree class. 2. Fixes a bug in which a number whose value matches an endpoint, was causing #path_to to run-away. The method now includes a guard to return the endpoint when the value of number matches it. 3. Adds the #to_node method to the String class, to facilitate converting strings like "1/0" into FractionTree:Nodes.
These changes continue the re-organization and re-assignment of responsibilities started in the previous commit. Changes include: * Introduce matrices to generate paths * Move node related methods to instance methods in the Node class * Add caching in the FractionTree class for faster lookups of nodes * Avail a more flexible control of the fraction tree's range * Add #to_node methods in Ruby primitive classes * Add Stern-Brocot .encode and .decode methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are three commits: