Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom kibit rules #5

Closed
wants to merge 2 commits into from

Conversation

kapilreddy
Copy link
Contributor

project.clj will need to have following entry

:kibit {:rules (merge kibit.rules/rule-map
                      {:ctrl test/rules})
        :source-paths ["rules"]}

All namespaces found in source-paths dir will be required during kibit
run.

Update kibit version in project.clj and 'kibit-project'

This change is dependent on a change in kibit. clj-commons/kibit#139

We will have to follow these steps to push a new version of lein-kibit

  • Merge pull request #139 on kibit and release a new version
  • Update this pull request pointing to latest kibit, merge pull request and release lein-kibit

project.clj will need to have following entry

:kibit {:rules (merge kibit.rules/rule-map
                      {:ctrl test/rules})
        :source-paths ["rules"]}

All namespaces found in source-paths dir will be required during kibit
run.

Update kibit version in project.clj and 'kibit-project'
(let [src-paths (get-in project [:kibit :source-paths] ["rules"])
kibit-project `{:dependencies [[jonase/kibit "0.1.2"]]
:source-paths ~src-paths}
paths (seq (disj (set (concat (:source-paths project)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put the first arg to concat onto the line below?

@danielcompton
Copy link
Collaborator

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants