add Until method on clock interface #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clockwork package has a
Sincemethod for measuring duration between a time in the past and the current time.The go standard lib
timehas anUntilmethod, in addition toSince.There's quite a few cases (at least, in my software) where it would be far 'neater' to have
Untilthan doing the negative ofSince.This PR adds an
Untilmethod to the clock interface, with tests.I am not sure on what the general philosophy around this package is - i.e. if you even want
Until, but I thought it would be worthwhile to open a PR.Thank you for your work on Clockwork, I would be delighted to have any feedback to try and make my contributions better 😄