Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Chatter dependencies #552

Merged
merged 5 commits into from
Sep 20, 2023
Merged

Remove Chatter dependencies #552

merged 5 commits into from
Sep 20, 2023

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Sep 19, 2023 •
edited
Loading

  • Disabled Chatter in base scratch org file config/scratch-orgs/base-scratch-def.json
  • Removed all Chatter components in FlexiPage metadata to remove a dependency on Chatter being enabled
    • Several of the objects & fields still have Chatter feed tracking enabled (<trackFeedHistory>true</trackFeedHistory> in the field XML), but the platform seems to gracefully handle that situation
      • When Chatter is enabled in the org, the trackFeedHistory node is used to automatically enable Chatter's feed tracking in the appropriate fields
      • When Chatter is disabled in the org, the fields still deploy & the trackFeedHistory node is ignored
  • Improved some tests in LoggerEmailSender_Tests

@jongpie jongpie added Type: Enhancement New feature or request Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package labels Sep 19, 2023
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 19, 2023 15:49 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org September 19, 2023 15:58 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 19, 2023 15:58 — with GitHub Actions Inactive
@jongpie
Temporarily updating build.yml to delete problematic Experience Cloud…
57e40f0 
… data before generating new package versions
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 19, 2023 16:50 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org September 19, 2023 16:50 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org September 19, 2023 16:59 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org September 19, 2023 17:31 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 19, 2023 17:31 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org September 19, 2023 17:31 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the feature/remove-chatter-dependencies branch from 91ab6e1 to eb7e168 Compare September 19, 2023 19:38
@jongpie jongpie had a problem deploying to Experience Cloud Scratch Org September 19, 2023 19:42 — with GitHub Actions Failure
@jongpie
Fixed some testing in LoggerEmailSender_Tests to ensure tests pass in…
9a6b32f 
… orgs with & without email deliverability enabled
@jongpie jongpie force-pushed the feature/remove-chatter-dependencies branch from eb7e168 to 9a6b32f Compare September 19, 2023 20:06
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org September 19, 2023 20:10 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org September 19, 2023 20:10 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org September 19, 2023 20:18 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Demo Org September 19, 2023 20:32 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage is 85.71% of modified lines.

❗ Current head 9a6b32f differs from pull request most recent head 491718f. Consider uploading reports for the commit 491718f to get more accurate results

Files Changed Coverage
...-logger/core/main/logger-engine/classes/Logger.cls ø
.../main/log-management/classes/LoggerEmailSender.cls 85.71%

📢 Thoughts on this report? Let us know!.

@jongpie jongpie marked this pull request as ready for review September 20, 2023 13:39
@jongpie jongpie merged commit fb6cd3e into main Sep 20, 2023
@jongpie jongpie deleted the feature/remove-chatter-dependencies branch September 20, 2023 13:46
@jongpie jongpie added the Layer: Log Management Items related to the custom objects & Logger Console app label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Type: Enhancement New feature or request
Projects
None yet
Milestone
Version 4.12.0: Winter '24 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jongpie @actions-user