Add setRecord method to LogEntryEventBuilder for handling Set of Ids and List of Ids #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamessimone
reviewed
Nov 1, 2024
nebula-logger/core/main/logger-engine/classes/LogEntryEventBuilder.cls
Outdated
Show resolved
Hide resolved
nebula-logger/core/main/logger-engine/classes/LogEntryEventBuilder.cls
Outdated
Show resolved
Hide resolved
jamessimone
previously approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Looks good @alanjaouen - @jongpie will create a new package version for you
|
thanks for your feedback please rebase before merging to squash commits together |
…t<Id>) works as expected
…erable', added a name-shadow class for 'Iterable' This ensures Nebula Logger can be installed/works correctly in orgs that decide to use name-shadowing
jongpie
added
Type: Enhancement
jongpie
force-pushed
the
feat/relatedRecordsIds
branch
from
ccc4377
to
18cfb37
Compare
jongpie
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
@alanjaouen thanks so much for working on this, and @jamessimone thanks for reviewing it! I've pushed up a couple of small changes:
- Rebased the branch to
main - Added an extra test method to validate that
List<Id>also works as a parameter forsetRecord() - Made the reference to
Iterableuse a fully qualified refSystem.Iterable - Bumped the version number & name + created a new package version
I'm working on release notes now, I should have this released later today.
jongpie
approved these changes
Nov 7, 2024
jongpie
changed the title
|
Nice, thanks! |
|
Alright, this is now available in release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As LogEntryEventBuilder provide methods
setRecord(SObject record)andsetRecord(List<SObject> records), I sugest to addsetRecord(Set<Id> recordsIds)to completesetRecord(Id recordId)I reused
setRecord(List<SObject> records)to avoid duplicating code, but feel free to give me your though on this