Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: draft access publicly, invalid Petition ID and Petition Not Found Issues + Enhanced 404 page #104

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: draft access publicly, invalid Petition ID and Petition Not Found Issues + Enhanced 404 page #104

wants to merge 3 commits into from
+246 −85

Commits on Sep 14, 2024

  1. fix: invalid petition id and notfound issue resolved. Also enhanced t… 

    …he error page and component.

- Petition Id invalid issue fixed
- Petition Not found issue fixed
- custom error screen and component added
- Update NotFound component to use ErrorGui component for displaying 404 error.
- Remove unnecessary code and improve code readability.
    @monzim
    monzim committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    77ee942 View commit details
    Browse the repository at this point in the history

  2. fix: Resolve invalid petition ID and not found issue 

    Enhance error page and component. Also update the next/navigation import in _page.tsx to include notFound.

Add new files for error and not found pages in the petitions/[id] directory.

Update ErrorGui component to remove unused imports and replace the AlertTriangle icon with FaceFrownIcon for the 404 error page.
    @monzim
    monzim committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    210488d View commit details
    Browse the repository at this point in the history

  3. fix: issue Deleted petition edit link still accessible jonogon#83 and… 

    … Saved draft petitions are accessible by public jonogon#65. Also update the PetitionActionButton.
    @monzim
    monzim committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    2358873 View commit details
    Browse the repository at this point in the history