Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLR for SMS with more than one segment #1157

Merged
merged 10 commits into from
Mar 27, 2024
Merged

DLR for SMS with more than one segment #1157

merged 10 commits into from
Mar 27, 2024

Conversation

Herneto
Copy link

@Herneto Herneto commented Nov 19, 2023

Fixes

#1136

Description

I was experiencing the issue #1136 where I didn't receive trought HTTP the SMSC's DLR for sms with more than one segment.

It was happening because it always expect the SMSC's DLR for the first pdu what works for sms with one segment.

I just fixed so that SMSC's DLR is expected for the first pdu for sms with one segment and expected for the last pdu for sms with more than one segment.

@farirat farirat changed the base branch from master to 0.11.1 November 20, 2023 08:26
@farirat
Copy link
Contributor

farirat commented Nov 23, 2023

Hello @Herneto
Am running CI tests and let's hope this would pass them.

@farirat
Copy link
Contributor

farirat commented Nov 23, 2023

Hey @Herneto please take a look to the failed tests.

@BlackOrder
Copy link
Contributor

@farirat farirat merged commit 7c1f406 into jookies:0.11.1 Mar 27, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants