Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button modal #512

Open
wants to merge 2 commits into
base: 4.0-dev
Choose a base branch
from
Open

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Sep 4, 2022

Pull Request for Issue #476 .

Summary of Changes

Remove unused condition, Change button to a link

Testing Instructions

Add several links to one weblink category, add a menuitem of typ Weblink category for this category

Expected result

All links look and behave similar.
grafik

Actual result

Links with taget modal are displayed as buttons, so lose underline and focus border on hover, have more padding than other links

Documentation Changes Required

<?php else : ?>
<li class="list-group mt-3">
<?php endif; ?>
<li class="list-group mt-3">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave the class system-unpublished as how it is. It gives a way to allow target unpublished weblink items (note that on this page, we also display unpublished items for users with core.edit or core.edit.state permission) via css if needed. For your information, we also have that css class for other core components like com_contact https://github.com/joomla/joomla-cms/blob/4.2-dev/components/com_contact/tmpl/category/default_items.php#L96 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants