Skip to content

Commit

Permalink
fix: correctly use typescript in test
Browse files Browse the repository at this point in the history
  • Loading branch information
jooy2 committed Sep 22, 2024
1 parent 50af35d commit c7cd07a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 8 deletions.
8 changes: 4 additions & 4 deletions tests/fixtures.mts
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import * as base from '@playwright/test'
import { _electron as electron } from 'playwright'
import { _electron as electron, Page, ElectronApplication } from 'playwright'
import { join } from 'path'
import { main } from '../package.json'
import TestUtil from './testUtil.mjs'

let appElectron
let page
let appElectron: ElectronApplication
let page: Page

const __cwd = process.cwd()
const __isCiProcess = process.env.CI === 'true'
Expand Down Expand Up @@ -52,7 +52,7 @@ export const beforeAll = async () => {
}
})

await base.expect(evaluateResult.packaged, 'app is not packaged').toBe(false)
base.expect(evaluateResult.packaged, 'app is not packaged').toBe(false)
}

export const afterAll = async () => {
Expand Down
17 changes: 13 additions & 4 deletions tests/testUtil.mts
Original file line number Diff line number Diff line change
@@ -1,11 +1,20 @@
import { Page } from 'playwright'
import { TestInfo } from 'playwright/test'

export default class TestUtil {
constructor(page, testInfo, testScreenshotPath) {
_page: Page

_testInfo: TestInfo

_testScreenshotPath: string

constructor(page: Page, testInfo: TestInfo, testScreenshotPath: string) {
this._page = page
this._testInfo = testInfo
this._testScreenshotPath = testScreenshotPath
}

async captureScreenshot(pageInstance, screenshotName) {
async captureScreenshot(pageInstance: Page, screenshotName: string) {
if (!pageInstance) {
return
}
Expand All @@ -19,13 +28,13 @@ export default class TestUtil {
}
}

async onTestError(error) {
async onTestError(error: Error) {
const titleLists = [...this._testInfo.titlePath]
titleLists.shift()
const title = titleLists.join('-')

await this.captureScreenshot(this._page, `${title}_${Date.now()}`)

return new Error(error)
return new Error(error.message)
}
}

0 comments on commit c7cd07a

Please sign in to comment.