Add DAJAXICE_FETCH_CSRF_FROM_FIELD in order to avoid reading CSRF cookie #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement DAJAXICE_FETCH_CSRF_FROM_FIELD If you have set httponly attribute on the CSRFcookie, javascript will not be able to read CSRF cookie. Instead we can fetch the CSRF token from the hidden field generated in the form by CSRF middleware.
|
Hallo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A security recommendation is to mark all cookies httponly which disallows javascript from reading the cookies. This causes problems with dajaxice. This change adds a configuration option to pull the CSRF token from the form field rather than the cookie.