Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type-hinting for reserved properties #84

Closed

Conversation

mindplay-dk
Copy link
Contributor

I attempted to add type-checking for key and the life-cycle attributes.

@andrewiggins can you take a look?

This works towards #36 but doesn't complete it - we still need types for for HTML/SVG attributes.

@jorgebucaran previous PRs are ruined - displaying unrelated comments on the page and whatnot. I have no idea how else to fix this, so I will count the PR history as lost. I'm opening new branches and new PRs cherry-picking my own commits by hand.

@codecov-io
Copy link

codecov-io commented Jan 7, 2018

Codecov Report

Merging #84 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #84   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         119    119           
  Branches       38     38           
=====================================
  Hits          119    119

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c9b87...5b4756a. Read the comment docs.

@jorgebucaran
Copy link
Owner

jorgebucaran commented Jan 7, 2018

Thanks, @mindplay-dk! Before giving up, would you have a look at this link? There's hope and if it does work we could unruin your PRs. 🙏

@jorgebucaran
Copy link
Owner

@mindplay-dk See comment above.

@mindplay-dk
Copy link
Contributor Author

@jorgebucaran this is all ancient greek to me - I really don't understand more than the bare minimum of git, just enough to get by on a daily basis. (I visit this site a lot 😆 )

No worries though, most of my branches are garbage/experiments, and cherry-picking the rest of them wasn't that bad. I'm sorry we lost the PR history, but, that's the best I can do 🙄

@jorgebucaran
Copy link
Owner

@mindplay-dk I like that site hehe.

@jorgebucaran jorgebucaran added the types Strings, numbers, booleans label Jan 7, 2018
@mindplay-dk
Copy link
Contributor Author

Closed without comment?

For the record, life-cycle methods are still missing from declarations.

I don't feel like PR'ing this a third time 🙄

@jorgebucaran jorgebucaran reopened this May 4, 2018
@jorgebucaran
Copy link
Owner

I ended up getting rid of the .d.ts file. I'm of course happy to merge a new PR with a new typings file for the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types Strings, numbers, booleans
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants