ordering -> internal_ordering (thofma#1402)

* `ordering` -> `internal_ordering` * Bump AbstractAlgebra and Nemo * Adjust to `kernel` methods being removed in AbstractAlgebra
joschmitt · Feb 20, 2024 · d2620fb · d2620fb
1 parent 77b2fdf
commit d2620fb
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/Project.toml b/Project.toml
@@ -28,7 +28,7 @@ GAPExt = "GAP"
 PolymakeExt = "Polymake"
 
 [compat]
-AbstractAlgebra = "^0.39.0"
+AbstractAlgebra = "^0.40.0"
 Dates = "1.6"
 Distributed = "1.6"
 GAP = "0.9.6, 0.10"
@@ -37,7 +37,7 @@ LazyArtifacts = "1.6"
 Libdl = "1.6"
 LinearAlgebra = "1.6"
 Markdown = "1.6"
-Nemo = "^0.42.1"
+Nemo = "^0.43.0"
 Pkg = "1.6"
 Polymake = "0.10, 0.11"
 Printf = "1.6"

diff --git a/src/NumField/NfAbs/MPolyAbsFact.jl b/src/NumField/NfAbs/MPolyAbsFact.jl
@@ -1343,7 +1343,7 @@ function absolute_multivariate_factorisation(a::QQMPolyRingElem)
     uni_sub = zeros(Hecke.Globals.Qx, nvars(R))
     uni_sub[vars[1]] = gen(Hecke.Globals.Qx)
     K1, alpha = number_field(evaluate(a, uni_sub), cached = false)
-    R1 = polynomial_ring(K1, map(string, symbols(R)), ordering = ordering(R), cached = false)[1]
+    R1 = polynomial_ring(K1, map(string, symbols(R)), internal_ordering = internal_ordering(R), cached = false)[1]
     A = map_coefficients(K1, a, parent = R1)
     x = gen(R1, vars[1])
     return (unit, [x - alpha, divexact(A, x - alpha)])
@@ -1352,7 +1352,7 @@ function absolute_multivariate_factorisation(a::QQMPolyRingElem)
     bi_sub[vars[2]] = y
     f, fbar = absolute_bivariate_factorisation(evaluate(a, bi_sub))
     K1 = base_ring(f)
-    R1 = polynomial_ring(K1, map(string, symbols(R)), ordering = ordering(R), cached = false)[1]
+    R1 = polynomial_ring(K1, map(string, symbols(R)), internal_ordering = internal_ordering(R), cached = false)[1]
     revsub = [gen(R1, vars[1]), gen(R1, vars[2])]
     return (unit, [evaluate(f, revsub), evaluate(fbar, revsub)])
   end
@@ -1416,7 +1416,7 @@ function absolute_multivariate_factorisation(a::QQMPolyRingElem)
   f, fbar = absolute_bivariate_factorisation(bi_a)
 
   K1 = base_ring(f)
-  R1 = polynomial_ring(K1, map(string, symbols(R)), ordering = ordering(R), cached = false)[1]
+  R1 = polynomial_ring(K1, map(string, symbols(R)), internal_ordering = internal_ordering(R), cached = false)[1]
   f = _yzero_image(R1, f, mainvar)
   fbar = _yzero_image(R1, fbar, mainvar)
 

diff --git a/src/NumFieldOrd/NfOrd/MaxOrd/MaxOrd.jl b/src/NumFieldOrd/NfOrd/MaxOrd/MaxOrd.jl
@@ -345,7 +345,7 @@ function _radical_by_trace(O::AbsSimpleNumFieldOrder, q::ZZRingElem)
   d = degree(O)
   K = nf(O)
   R = residue_ring(FlintZZ, q, cached=false)[1]
-  B = kernel(R, trace_matrix(O); side = :right)
+  B = kernel(change_base_ring(R, trace_matrix(O)); side = :right)
   M2 = zero_matrix(FlintZZ, d, d)
   for i = 1:ncols(B)
     for j = 1:d
@@ -945,7 +945,7 @@ function pradical_trace1(O::AbsSimpleNumFieldOrder, p::IntegerUnion)
   hnf_modular_eldiv!(M1, ZZRingElem(p), :lowerleft)
   I1 = ideal(O, p, gen2)
   I1.basis_matrix = M1
-  B = kernel(F, M; side = :right)
+  B = kernel(change_base_ring(F, M); side = :right)
   if iszero(ncols(B))
     return ideal(O, p)
   end