Skip to content

Commit

Permalink
merge changes from joyfullservice/dev (#12)
Browse files Browse the repository at this point in the history
* Avoid redundant scans for legacy source files

 These calls only need to be run during a full export. Definitely not repeated for each object exported. We may do some further cleanup later as some of these legacy files are far enough removed from the current version that the checks are probably no longer needed. See joyfullservice#527

* Improve performance on get relations QuickCount

When working over a VPN on a database with linked tables, DCount was significantly faster in quickly getting a count of relationships, cutting down overall export (scan) time significantly.

* Fix incompatible Access SQL data type

Fixes joyfullservice#533

* Remove orphaned TableDef *.sql files

Include *.sql in the list of extensions related to TableDef objects. Fixes joyfullservice#536

---------

Co-authored-by: joyfullservice <[email protected]>
  • Loading branch information
josef-poetzl and joyfullservice authored Oct 8, 2024
1 parent c9ce015 commit 451820b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Version Control.accda.src/modules/clsDbRelation.cls
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ End Property
'
Private Property Get IDbComponent_QuickCount() As Long
Static lngCount As Long
If lngCount = 0 Then lngCount = CurrentDb.Relations.Count - 1
' DCount is much faster than CurrentDb.Relations.Count in some cases.
If lngCount = 0 Then lngCount = DCount("*", "MSysRelationships") - 1
IDbComponent_QuickCount = lngCount + 1
End Property

Expand Down
3 changes: 2 additions & 1 deletion Version Control.accda.src/modules/clsDbTableDef.cls
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,7 @@ Private Function GetTypeString(intType As DAO.DataTypeEnum) As String
Case dbMemo: GetTypeString = "LONGTEXT"
Case dbDouble: GetTypeString = "DOUBLE"
Case dbSingle: GetTypeString = "SINGLE"
Case dbByte: GetTypeString = "UNSIGNED BYTE"
Case dbByte: GetTypeString = "BYTE"
Case dbInteger: GetTypeString = "SHORT"
Case dbLong: GetTypeString = "LONG"
Case dbNumeric: GetTypeString = "NUMERIC"
Expand Down Expand Up @@ -802,6 +802,7 @@ Private Property Get IDbComponent_FileExtensions() As Collection
Set IDbComponent_FileExtensions = New Collection
IDbComponent_FileExtensions.Add "xml"
IDbComponent_FileExtensions.Add "json"
IDbComponent_FileExtensions.Add "sql"
End Property


Expand Down

0 comments on commit 451820b

Please sign in to comment.