Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXIF GPS metadata extraction on mobile #360

Merged
merged 19 commits into from
Aug 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
9c0e135
WIP Add bottom-right button to open console via eruda, see https://gi…
josephfrazier Aug 14, 2022
385c9eb
Upgrade exifr from 6.0.0 to 7.1.3 to see if that helps
josephfrazier Aug 16, 2022
7f6ca8b
WIP Log full Exifr parse output to console
josephfrazier Aug 21, 2022
c521fba
yarn add md5
josephfrazier Aug 21, 2022
4208a1b
WIP log md5sum of image
josephfrazier Aug 21, 2022
e76e95a
Add test image for mobile EXIF metadata extraction bug
josephfrazier Aug 21, 2022
be4c616
yarn add object-hash
josephfrazier Aug 21, 2022
7d5cb1a
Use object-hash instead of md5, due to https://github.com/pvorb/node-…
josephfrazier Aug 21, 2022
ac479f4
Remove `accept` attribute from file input elements, since Android str…
josephfrazier Aug 21, 2022
a60fc46
Revert "Use object-hash instead of md5, due to https://github.com/pvo…
josephfrazier Aug 21, 2022
f155521
Revert "yarn add object-hash"
josephfrazier Aug 21, 2022
78cb364
Revert "Add test image for mobile EXIF metadata extraction bug"
josephfrazier Aug 21, 2022
3f54c52
Revert "WIP log md5sum of image"
josephfrazier Aug 21, 2022
8b21338
Revert "yarn add md5"
josephfrazier Aug 21, 2022
8cacd96
Revert "WIP Log full Exifr parse output to console"
josephfrazier Aug 21, 2022
eee6b2a
Revert "Upgrade exifr from 6.0.0 to 7.1.3 to see if that helps"
josephfrazier Aug 21, 2022
855c640
Revert "WIP Add bottom-right button to open console via eruda, see ht…
josephfrazier Aug 21, 2022
429304f
Update Home component snapshot
josephfrazier Aug 22, 2022
a931dd7
Merge branch 'main' into mobile.console
josephfrazier Aug 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/routes/home/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,6 @@ class Home extends React.Component {
onDrop={attachmentData => {
this.handleAttachmentData({ attachmentData });
}}
accept="image/*, video/*"
style={{
position: 'fixed',
top: 0,
Expand Down Expand Up @@ -1001,7 +1000,6 @@ class Home extends React.Component {
>
<fieldset disabled={this.state.isSubmitting}>
<FileReaderInput
accept="image/*"
multiple
as="buffer"
onChange={this.handleAttachmentInput}
Expand All @@ -1010,20 +1008,7 @@ class Home extends React.Component {
margin: '1px',
}}
>
<button type="button">Add picture(s)</button>
</FileReaderInput>

<FileReaderInput
accept="video/*"
multiple
as="buffer"
onChange={this.handleAttachmentInput}
style={{
float: 'left',
margin: '1px',
}}
>
<button type="button">Add video(s)</button>
<button type="button">Add pictures/videos</button>
</FileReaderInput>

<div
Expand Down
33 changes: 1 addition & 32 deletions src/routes/home/__snapshots__/Home.test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,6 @@ exports[`Home renders children correctly 1`] = `
}
>
<input
accept="image/*"
multiple={true}
onChange={[Function]}
onClick={[Function]}
Expand All @@ -221,36 +220,7 @@ exports[`Home renders children correctly 1`] = `
<button
type="button"
>
Add picture(s)
</button>
</div>
<div
className="_react-file-reader-input"
onClick={[Function]}
style={
Object {
"float": "left",
"margin": "1px",
}
}
>
<input
accept="video/*"
multiple={true}
onChange={[Function]}
onClick={[Function]}
style={
Object {
"position": "absolute",
"top": "-9999px",
}
}
type="file"
/>
<button
type="button"
>
Add video(s)
Add pictures/videos
</button>
</div>
<div
Expand Down Expand Up @@ -808,7 +778,6 @@ exports[`Home renders children correctly 1`] = `
</main>
</div>
<input
accept="image/*, video/*"
autoComplete="off"
disabled={false}
multiple={true}
Expand Down