Use early return in downscaleForPlateRecognizer
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A user found an image that, despite already being less than 4096 pixels wide, remained larger than the maximum filesize accepted by platerecognizer, even after being downscaled. This change makes it so that we scale it further down to 2048 pixels wide if it's still too big after being scaled to 4096. See here for more context: https://reportedcab.slack.com/archives/C7Z0BHMMY/p1734719601962699?thread_ts=1733722096.369269&cid=C7Z0BHMMY: > just tried that one locally, and it looks like the image is too big > for the ALPR API, even after the webapp downscales it. Guess I need to > tweak that to squeeze it down further, yet again... > > image buffer length BEFORE sharp: 4855730 bytes > image buffer length AFTER sharp: 2589893 bytes > orientImageBuffer: 187.262ms > file size is greater than maximum of 2411654 bytes, attempting to scale down to width of 4096 > file size after scaling down: 2426287 bytes > STARTING platerecognizer > /platerecognizer plate-reader got an error with first token, trying second > /platerecognizer plate-reader { > platerecognizerRes: Response { > size: 0, > timeout: 0, > [Symbol(Body internals)]: { body: [PassThrough], disturbed: false, error: null }, > [Symbol(Response internals)]: { > url: 'https://api.platerecognizer.com/v1/plate-reader/', > status: 413, > statusText: 'Request Entity Too Large', > headers: [Headers], > counter: 0 > } > } > }
This makes it easier for me to read.
josephfrazier
temporarily deployed
to
reported-web-downscalef-y8k5lh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier for me to read.