Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev peerly #165

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Dev peerly #165

wants to merge 6 commits into from

Conversation

omkar-20
Copy link

Ticket Links:

  • Add links for the Trello ticket or corresponding PR from other repo. Keep your ticket and sub-tasks updated.

Pull Request Description:

  • Context of the PR and a brief on approach taken.
  • Added minimum 150 character validation for description box

Pull Request Submission Checklist:

  • Add an x in between the brackets to check off a relevant item, eg: [x]

  • [ x] Self-reviewed the code prior to submitting PR

  • [ x] Done a thorough testing on local

  • [ x] Make sure no eslint and typescript issues.

  • Update Trello ticket and sub-tasks status


Deployment Steps:

  • If it does not exist then mention 'N/A'.

Screenshots/Videos:

  • Please include screenshots, animated gif or screencast of your changes in action.

1000139378

value={value}
multiline
/>
<Typography style={styles.noteText}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text field should toggle between helper text and error messages. We should avoid showing both simultaneously, especially when they have same text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants